Deimos summitprep#9
Open
weatherhead99 wants to merge 204 commits intomainfrom
Open
Conversation
Adding updates to deimos_dev from last j-bichel/deimos_dev commit
…te to line transfer
…tories/wdlfiles into j-bichel/deimos_dev Additional details to .waveform
- about to test VRD modulation
… and modes need to be altered
…arallels a little bit
prkrtg
approved these changes
Apr 28, 2026
mikelangmayr
approved these changes
Apr 28, 2026
Contributor
mikelangmayr
left a comment
mikelangmayr
left a comment
There was a problem hiding this comment.
Looks good to merge, once WDL has caught up we can add a workflow pipeline for building this ACF file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically all the work done on detectors for DEIMOS since start of 2025.
Base structure of working science and FCS modes is complete. There is stub support for coincident parallel clocking which will likely be enabled once we can optimise it on the real focal plane.
This does not build with vanilla WDL due to a bunch of bugfixes that were needed. The working wdl with various fixes can be found in
wdlrepotest_pgupta_fptbranch.