This repository was archived by the owner on Apr 5, 2019. It is now read-only.
Send response data in renderPage attribute#215
Open
NotBobTheBuilder wants to merge 1 commit intoCampFireManager:masterfrom
Open
Send response data in renderPage attribute#215NotBobTheBuilder wants to merge 1 commit intoCampFireManager:masterfrom
NotBobTheBuilder wants to merge 1 commit intoCampFireManager:masterfrom
Conversation
Previously this data was sent in two places - "renderPage" and the class name of the entity that was sent.
Eg:
{
"renderPage": data here...
"Collection_Timetable": same data here...
}
This patch fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is hacky and undoubtedly needs a pair of eyes on it to find a better way.
Previously this data was sent in two places - "renderPage" and the class name of the entity that was sent.
Eg:
This patch fixes that.
It also avoids a collision whereby login information - stored in
Object_User- would clash with the response of an API call to/rest/user.