Skip to content

Conversation

@StickmanRed
Copy link
Collaborator

@StickmanRed StickmanRed commented Feb 1, 2026

Fixes clip bug

The bug was caused by _willBeRemoved being set to true by clip.remove() in Wick.Frame.addClip. Bugfix tested through console on Candlestick.

Requires engine build to test

Fixes a bug where breaking apart a parent clip causes child clips to be undeletable.
@bogoddr
Copy link
Collaborator

bogoddr commented Feb 11, 2026

Ooh I ran into this during the gamejam haha. Thanks for finding a fix

Do you still have the code you used to verify this fix? I'd like to add it to the engine test suite

@StickmanRed
Copy link
Collaborator Author

Not really, I just used the inspector "Break Apart" action and manually deleted the child clips... this code could be used to verify it though

project.activeFrame.clips[0].breakApart();
let clip1 = project.activeFrame.clips[0];
clip1.remove();
// clip1.parent should equal null

also, about the testing, would it be correct to add the bugfix test code after this line in test.Wick.Clip.js?

@bogoddr
Copy link
Collaborator

bogoddr commented Feb 12, 2026

Yup, I'd add the test there with a comment above it like

// Check that child clips are deletable after break apart (https://github.com/Candlestickers/Candlestick/pull/105)

I'm not sure if running the tests still works on node14, but they are working on the node 24 branch with new instructions: d4797dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants