-
-
Notifications
You must be signed in to change notification settings - Fork 422
Vibrational-relaxation from plasma treatment enhancements #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gaetanosaure
wants to merge
27
commits into
Cantera:main
Choose a base branch
from
Gaetanosaure:vibrational-relaxation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2a65df0
[kinetics] Add VibrationalRelaxationRate reaction rate
Gaetanosaure 54b4238
rebase and resolve conflicts - [thermo] Warn about misdeclared vibrat…
Gaetanosaure abd1c09
Updated TwoTempPlasmaRate class comments and formatting
Gaetanosaure 927ab86
accept only b-gas as entry for yaml
Gaetanosaure 0ba7ea0
update two-temperature-plasma yaml documentation
Gaetanosaure 085147d
simplify twoTempPlasmaRate anymap constructor code
Gaetanosaure 6260a5a
updated cantera.bib
Gaetanosaure f31351d
update documentation content and format in VibrationalRelaxationRate.h
Gaetanosaure ad4f41d
line length formatting + further formatting of VibrationalRelaxationR…
Gaetanosaure 54d996b
modify basic formatting in vibrationalRelaxationRate.cpp
Gaetanosaure 1165179
Code formatting and commenting in Plasma phase .h and .cpp
Gaetanosaure dc3580d
Add comments and simplify some code bits in vibrationalRelaxationRate…
Gaetanosaure 0437f84
correct mistake made on vibration-model assignment during previous co…
Gaetanosaure c639bb2
drop starikovskiy model in-house sign convention to generalise the ex…
Gaetanosaure 53a1605
replace all YAML parameters' underscores with hyphens
Gaetanosaure 07807c9
centralise string handling for often used strings to avoid typos on them
Gaetanosaure 624c0fc
make required and forbidden key tests more compact
Gaetanosaure 32cb13b
make data input in setParameters more readable and compact
Gaetanosaure 133d934
make sameComposition more compact and readable
Gaetanosaure 06a051b
correct typos and finish corrections that were forgotten during previ…
Gaetanosaure 72d98c6
Factor vibrational relaxation rate-constant map parsing and correct T…
Gaetanosaure 5b2e735
Split vibrational relaxation parameter treatment by model and use swi…
Gaetanosaure e773816
split getParameter by model as well
Gaetanosaure 162e01e
validateDetailedRelaxationReaction made a little more compact and rea…
Gaetanosaure cc10c0c
update reactions documentation for the vibration-relaxation reaction …
Gaetanosaure b50eb2f
correct mispelling in code comments
Gaetanosaure 5338645
added the T-inv optional parameter in TwoTempPlasmaRate, corrected mi…
Gaetanosaure File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,22 @@ @article{blowers2000 | |
| url = {https://dx.doi.org/10.1002/aic.690461015}, | ||
| volume = {46}, | ||
| year = {2000}} | ||
| @book{capitelli2013, | ||
| title={Plasma kinetics in atmospheric gases}, | ||
| author={Capitelli, Mario and Ferreira, Carlos M and Gordiets, Boris F and Osipov, Alexey I}, | ||
| volume={31}, | ||
| year={2013}, | ||
| publisher={Springer Science \& Business Media} | ||
| } | ||
| @article{castela2016, | ||
| title={Modelling the impact of non-equilibrium discharges on reactive mixtures for simulations of plasma-assisted ignition in turbulent flows}, | ||
| author={Castela, Maria and Fiorina, Beno{\^\i}t and Coussement, Axel and Gicquel, Olivier and Darabiha, Nasser and Laux, Christophe O}, | ||
| journal={Combustion and flame}, | ||
| volume={166}, | ||
| pages={133--147}, | ||
| year={2016}, | ||
| publisher={Elsevier} | ||
| } | ||
| @book{chapman1970, | ||
| title={The mathematical theory of non-uniform gases}, | ||
| author={S.~Chapman and T.~G.~Cowling}, | ||
|
|
@@ -111,6 +127,16 @@ @misc{gou2011 | |
| howpublished = {\url{https://engine.princeton.edu/model-reduction/}}, | ||
| note = {Accessed: 2022-04-25}, | ||
| year = {2011}} | ||
| @article{guerra2019, | ||
| title={Modelling N2--O2 plasmas: volume and surface kinetics}, | ||
| author={Guerra, Vasco and Tejero-del-Caz, Antonio and Pintassilgo, Carlos D and Alves, Lu{\'\i}s L}, | ||
| journal={Plasma Sources Science and Technology}, | ||
| volume={28}, | ||
| number={7}, | ||
| pages={073001}, | ||
| year={2019}, | ||
| publisher={IOP Publishing} | ||
| } | ||
|
Comment on lines
+130
to
+139
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please include the DOI/URL fields for all journal articles. |
||
| @article{gudmundsson2001, | ||
| author = {J.~T.~Gudmundsson}, | ||
| journal = {Plasma Sources Science and Technology}, | ||
|
|
@@ -390,6 +416,16 @@ @book{poling2001 | |
| isbn = {0-07-149999-7}, | ||
| year = {2001}, | ||
| edition = {Fifth}} | ||
| @article{popov2016, | ||
| title={Kinetics of plasma-assisted combustion: effect of non-equilibrium excitation on the ignition and oxidation of combustible mixtures}, | ||
| author={Popov, NA}, | ||
| journal={Plasma Sources Science and Technology}, | ||
| volume={25}, | ||
| number={4}, | ||
| pages={043002}, | ||
| year={2016}, | ||
| publisher={IOP Publishing} | ||
| } | ||
| @phdthesis{prager2005, | ||
| author = {J.~Prager}, | ||
| school = {Technische Universität Darmstadt}, | ||
|
|
@@ -470,6 +506,16 @@ @article{singal2024 | |
| number = {1--4}, | ||
| pages = {105779}, | ||
| year = {2024}} | ||
| @article{starikovskiy2013, | ||
| title = "Plasma-assisted ignition and combustion", | ||
| journal = "Progress in Energy and Combustion Science", | ||
| volume = "39", | ||
| number = "1", | ||
| pages = "61 - 110", | ||
| year = "2013", | ||
| issn = "0360-1285", | ||
| author = "Andrey Starikovskiy and Nickolay Aleksandrov", | ||
| } | ||
| @article{stewart1989, | ||
| author = {P.~H.~Stewart and C.~W.~Larson and D.~Golden}, | ||
| journal = {Combustion and Flame}, | ||
|
|
@@ -570,6 +616,19 @@ @article{westbrook1981 | |
| doi = {10.1080/00102208108946970}, | ||
| URL = {https://doi.org/10.1080/00102208108946970}, | ||
| year = {1981}} | ||
| @article{zhong2023, | ||
| author = {Hongtao Zhong and Xingqian Mao and Ning Liu and Ziyu Wang and Timothy Ombrello and Yiguang Ju}, | ||
| doi = {10.1016/j.combustflame.2023.112948}, | ||
| issn = {15562921}, | ||
| pages = {112948}, | ||
| journal = {Combust. Flame}, | ||
| keywords = {Ammonia,Laser diagnostics,N2O/NOx chemistry,Nitrogen cycle,Plasmas,Sustainable energy}, | ||
| month = {10}, | ||
| publisher = {Elsevier Inc.}, | ||
| title = {{Understanding non-equilibrium N$_2$O/NO$_x$ chemistry in plasma-assisted low-temperature NH$_3$ oxidation}}, | ||
| volume = {256}, | ||
| year = {2023} | ||
| } | ||
| @article{zhu2006, | ||
| author = {H.~Zhu and R.~J.~Kee}, | ||
| journal = {Journal of The Electrochemical Society}, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct version of the book, right? https://link.springer.com/book/10.1007/978-3-662-04158-1
The publication year is 2000, not 2013. I think it would also be good to provide the DOI and URL fields based on that page for precision, and provide similar information for other books (at least ISBN if DOI is not available). Also, please note the formatting we apply to author names -- initials only for first/middle names, with periods, and
~to control spacing (though this doesn't actually affect HTML output as far as I know).