Skip to content

Stabilize Maestro CI runners#5

Closed
riderx wants to merge 5 commits intomainfrom
codex/roadmap-capability-contract
Closed

Stabilize Maestro CI runners#5
riderx wants to merge 5 commits intomainfrom
codex/roadmap-capability-contract

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Apr 8, 2026

What

  • stabilize Android Maestro CI execution and workflow wiring
  • keep iOS and Android example-app Maestro coverage running in GitHub Actions
  • add workflow dispatch support so branch-head validation can be rerun reliably

Why

  • the previous PR merged while these CI fixes were still in progress
  • Android Maestro was failing in CI for workflow/script reasons rather than product bugs
  • the branch needed a fresh PR for the remaining unmerged commits

How

  • fixed the Android workflow step so Gradle and Maestro run from the correct paths
  • removed the extra Android ADB port-forward that conflicted with Maestro's own forwarder
  • kept the branch-level workflow usable with manual dispatch for validation

Testing

  • GitHub Actions workflow Build source code and test it on commit 8c6026e
  • successful run: 24143425949
  • passed jobs: Build code and test, build_android, build_ios, guard_swiftpm_version, maestro_android, maestro_ios

Not Tested

  • no additional manual device testing outside the existing CI/example-app flows

Summary by CodeRabbit

  • Chores

    • Refactored Android testing infrastructure in CI pipeline with streamlined emulator setup and test execution
    • Added manual trigger capability to testing workflows
  • Documentation

    • Updated Android testing process documentation to clarify emulator bootstrap and ADB port-forwarding behavior

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 640addef-325d-439c-b5f6-49e8b3d810ef

📥 Commits

Reviewing files that changed from the base of the PR and between b489117 and 8c6026e.

📒 Files selected for processing (4)
  • .github/workflows/test.yml
  • example-app/README.md
  • example-app/scripts/run-maestro-android-ci.sh
  • example-app/scripts/run-maestro-android.sh

📝 Walkthrough

Walkthrough

The changes migrate Android Maestro CI testing from a custom Bash script to the android-emulator-runner GitHub Action, removing emulator setup logic from CI and simplifying the local test runner by eliminating explicit ADB port-forwarding steps.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test.yml
Added workflow_dispatch trigger; replaced custom emulator setup script with reactivecircus/android-emulator-runner@v2 action configured for API 34 google_atd target on pixel_6; adjusted job flow to assemble debug build, install APK, and run Maestro tests directly.
Script Removals & Updates
example-app/scripts/run-maestro-android-ci.sh, example-app/scripts/run-maestro-android.sh
Deleted entire CI emulator setup script (153 lines covering SDK tools detection, AVD creation, emulator startup); removed ADB port-forward and sleep delay from local runner.
Documentation
example-app/README.md
Clarified that CLI owns ADB port-forwarding setup; removed outdated references to script-level gRPC bridge forwarding.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Out went the scripts so long and grand,
In came the action, sleek and planned,
No emulator setup by our paw,
Just docker magic, without a flaw,
Maestro dances, faster still! 🎭

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/roadmap-capability-contract

Comment @coderabbitai help to get the list of available commands and usage tips.

@riderx
Copy link
Copy Markdown
Member Author

riderx commented Apr 8, 2026

Superseded by #6 from a fresh branch so GitHub Actions can attach the PR workflow correctly.

@riderx riderx closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant