-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync plus with upstream main (conflicts) #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: plus
Are you sure you want to change the base?
Changes from all commits
ae800df
95dc7d8
2a66b44
0969c5c
53c33b6
6037e38
dcc76c3
154f3ce
c5476c8
44e1cd5
0412d46
a125498
b10cd7f
a48ebb6
6994aaa
05b1c16
a55dc5e
a441280
ee304e3
fc9647f
7d001ac
bd29b99
5e82c89
782b9d9
5db81e6
3109d22
ae0e2dd
379101c
09770f7
8dddd0b
003099a
4e99598
14e4af2
afb80f2
a9f2181
d2ee84f
69476ab
f03cfbe
27e6aa8
39f084a
acb64ab
3d1f8d1
aa22484
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Close old issues that need reply | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 0 * * *" | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Close old issues that need reply | ||
| uses: imhoffd/needs-reply@v2 | ||
| with: | ||
| repo-token: ${{ secrets.BOT_TOKEN }} | ||
| issue-label: 'needs reply' | ||
| days-before-close: 7 | ||
| close-message: | | ||
| It looks like this issue didn't get the information it needed, so I'll close it for now. If I made a mistake, sorry! I am just a bot. | ||
|
|
||
| Have a great day! | ||
| Ionitron 💙 |
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,30 @@ | ||||||||||||||||
| name: Publish Native iOS Library | ||||||||||||||||
|
|
||||||||||||||||
| on: | ||||||||||||||||
| workflow_call: | ||||||||||||||||
| secrets: | ||||||||||||||||
| COCOAPODS_TRUNK_TOKEN: | ||||||||||||||||
| required: true | ||||||||||||||||
| workflow_dispatch: | ||||||||||||||||
|
|
||||||||||||||||
| jobs: | ||||||||||||||||
| publish-ios: | ||||||||||||||||
| runs-on: macos-15 | ||||||||||||||||
| timeout-minutes: 30 | ||||||||||||||||
| steps: | ||||||||||||||||
| - run: sudo xcode-select --switch /Applications/Xcode_26.0.app | ||||||||||||||||
| - run: xcrun simctl list > /dev/null | ||||||||||||||||
| - run: xcodebuild -downloadPlatform iOS | ||||||||||||||||
| - uses: actions/setup-node@v6 | ||||||||||||||||
| with: | ||||||||||||||||
| node-version: 22.x | ||||||||||||||||
| - uses: actions/checkout@v5 | ||||||||||||||||
| with: | ||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||
| ref: 'main' | ||||||||||||||||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't force the workflow to publish This release job ignores the triggering ref and always checks out Proposed fix - uses: actions/checkout@v5
with:
fetch-depth: 0
- ref: 'main'📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| - name: Install Cocoapods | ||||||||||||||||
| run: gem install cocoapods | ||||||||||||||||
| - name: Deploy to Cocoapods | ||||||||||||||||
| run: sh ./scripts/native-podspec.sh publish | ||||||||||||||||
| env: | ||||||||||||||||
| COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }} | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Does the GitHub Actions macos-15 runner image currently include /Applications/Xcode_26.0.app, and what Xcode app bundle paths are officially documented as preinstalled?💡 Result:
No, the GitHub Actions macos-15 runner image does not include /Applications/Xcode_26.0.app as a primary bundle path. It includes /Applications/Xcode_26.0.1.app with a symlink at /Applications/Xcode_26.0.app. The officially documented preinstalled Xcode app bundle paths on macos-15 (current image version 20260330.0336.1, macOS 15.7.5) are: - Xcode 26.3 (17C529): /Applications/Xcode_26.3.app (symlink: /Applications/Xcode_26.3.0.app) - Xcode 26.2 (17C52): /Applications/Xcode_26.2.app (symlink: /Applications/Xcode_26.2.0.app) - Xcode 26.1.1 (17B100): /Applications/Xcode_26.1.1.app (symlink: /Applications/Xcode_26.1.app) - Xcode 26.0.1 (17A400): /Applications/Xcode_26.0.1.app (symlink: /Applications/Xcode_26.0.app) - Xcode 16.4 (default, 16F6): /Applications/Xcode_16.4.app - Xcode 16.3 (16E140): /Applications/Xcode_16.3.app (symlink: /Applications/Xcode_16.3.0.app) - Xcode 16.0 (16A242d): /Applications/Xcode_16.app (symlinks: /Applications/Xcode_16.0.0.app, /Applications/Xcode_16.0.app, /Applications/Xcode.app) This information comes from the official runner-images repository's macos-15-Readme.md on the main branch, which documents the current production image used by GitHub Actions.
Citations:
The hardcoded Xcode path
/Applications/Xcode_26.0.appcurrently exists onmacos-15as a symlink, but relying on it is fragile.The path resolves via a symlink to
/Applications/Xcode_26.0.1.appon the current image. However, hardcoding to a specific version introduces maintenance risk if GitHub Actions removes or restructures that symlink in future runner updates. Consider using a dynamic approach (e.g., detecting the default Xcode viaxcode-select -porxcrun --version) to avoid coupled workflows.🤖 Prompt for AI Agents