chore: sync upstream PR #8521 - chore(cli): migrate changes for Capacitor 9 #81
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,9 @@ | ||||||||||||||||||
| distributionBase=GRADLE_USER_HOME | ||||||||||||||||||
| distributionPath=wrapper/dists | ||||||||||||||||||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-all.zip | ||||||||||||||||||
| networkTimeout=10000 | ||||||||||||||||||
| retries=0 | ||||||||||||||||||
| retryBackOffMs=500 | ||||||||||||||||||
|
Comment on lines
+3
to
+6
There was a problem hiding this comment. 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win Retries left at the Gradle-generated default (disabled) — consider enabling for CI resilience.
♻️ Enable wrapper download retries networkTimeout=10000
-retries=0
+retries=3
retryBackOffMs=500📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| validateDistributionUrl=true | ||||||||||||||||||
| zipStoreBase=GRADLE_USER_HOME | ||||||||||||||||||
| zipStorePath=wrapper/dists | ||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| include ':app' | ||
|
|
||
| apply from: 'capacitor.settings.gradle' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| ext { | ||
| minSdkVersion = 26 | ||
| compileSdkVersion = 37 | ||
| targetSdkVersion = 37 | ||
| androidxActivityVersion = '1.13.0' | ||
| androidxAppCompatVersion = '1.7.1' | ||
| androidxCoordinatorLayoutVersion = '1.3.0' | ||
| androidxCoreVersion = '1.19.0' | ||
| androidxFragmentVersion = '1.8.9' | ||
| coreSplashScreenVersion = '1.2.0' | ||
| androidxWebkitVersion = '1.16.0' | ||
| junitVersion = '4.13.2' | ||
| androidxJunitVersion = '1.3.0' | ||
| androidxEspressoCoreVersion = '3.7.0' | ||
| cordovaAndroidVersion = '15.0.0' | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Cap-go/capacitor-plus
Length of output: 2134
🏁 Script executed:
Repository: Cap-go/capacitor-plus
Length of output: 4208
Restore podspec lint in CI — commenting out
Validate native podspecremoves checks for bothios/Capacitor.podspecandios/CapacitorCordova.podspec;ios/package.json’s verify script only runs Xcode builds, so add this step back or replace it with an explicit lint elsewhere.🧰 Tools
🪛 zizmor (1.26.1)
[info] 131-131: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
🤖 Prompt for AI Agents