-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(recording): keep system audio on the recording timeline when delivery is intermittent #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
842b4bb
fix(recording): keep system audio on the recording timeline when deli…
richiemcilroy f1dac2c
chore: cargo fmt
richiemcilroy ff418c3
fix: clippy needless_update and clone_on_copy findings
richiemcilroy e40d244
test(recording): validate WASAPI loopback against a real endpoint in CI
richiemcilroy ace458d
chore: cargo fmt
richiemcilroy f7822eb
ci: verify Scream driver download by SHA-256 before install
richiemcilroy 69dc60f
ci: pin Scream 3.6 for the virtual audio device and bound the install…
richiemcilroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’re importing a cert from the downloaded zip straight into
LocalMachine\\TrustedPublisher. It’d be good to sanity-check the Authenticode signature first (at least ensure it’s actually signed and not hash-mismatched) before trusting the signer cert.