Update for prelude 1.0, expand the API, and improve the polyfill.#5
Open
rgrempel wants to merge 4 commits intoCapillarySoftware:masterfrom
Open
Update for prelude 1.0, expand the API, and improve the polyfill.#5rgrempel wants to merge 4 commits intoCapillarySoftware:masterfrom
rgrempel wants to merge 4 commits intoCapillarySoftware:masterfrom
Conversation
* Updates the code for purescript-prelude 1.0, and psc 0.9.1 * Updates the polyfill to match the spec more closely * Implements `cancelAnimationFrame` * Allows the scheduled effect to depend on the time value provided in the callback. * Adds tests The original API is mostly preserved, but now returns a `Request` instead of `Unit`, to allow for `cancelAnimationFrame` to work. So, it is technically a breaking change, but should not be difficult for existing code to adapt to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancelAnimationFrameThe original API is mostly preserved, but now returns a
Requestinstead ofUnit, to allow forcancelAnimationFrameto work. So, it is technically a breaking change, but should not be difficult for existing code to adapt to.