teachers frontend - initial version #2
teachers frontend - initial version #2adhithyasimha wants to merge 2 commits intoCapping-the-stone:mainfrom
Conversation
| <html lang="en" suppressHydrationWarning> | ||
| <body className={`font-sans ${GeistSans.variable} ${GeistMono.variable}`}> | ||
| {children} | ||
| <Analytics /> |
There was a problem hiding this comment.
This is only applicable if we are hosting this on vercel. It won't be.
| } | ||
|
|
||
| // John Doe's Python code - factorial function | ||
| const sampleKeystrokeLog1: KeystrokeEvent[] = [ |
There was a problem hiding this comment.
The event formats are not this. Please talk with the person who's doing backend to agree on an API contract. The backend person should in turn ask the person building the storage systems to set up a cron job and appropriate call backs
| position: number | ||
| content: string | ||
| } | ||
|
|
There was a problem hiding this comment.
All this data is statically instantiated, it must be fetched from an API. The API contract is important! This needs to work
|
|
||
| // John Doe's Python code - factorial function | ||
| const sampleKeystrokeLog1: KeystrokeEvent[] = [ | ||
| { timestamp: 0, type: "insert", position: 0, content: "def" }, |
There was a problem hiding this comment.
This assumes that all timestamps start form 0. The timestamps we use in our system is EPOCH timestamps. You'll either need a normalization step or amend your display pipeline.
| { timestamp: 2800, type: "insert", position: 40, content: "return" }, | ||
| { timestamp: 3200, type: "insert", position: 46, content: " " }, | ||
| { timestamp: 3300, type: "insert", position: 47, content: "1" }, | ||
| { timestamp: 3500, type: "insert", position: 48, content: "\n " }, |
There was a problem hiding this comment.
You will have 'delete' events as well. You'd know if you talked to the team to decide an API contract rather than prompting LLMs
|
|
||
| const assignments = ["Assignment 1", "Assignment 2", "Assignment 3", "Assignment 4"] | ||
|
|
||
| const studentsData = { |
There was a problem hiding this comment.
You can't have static data like this, use an API, a mock one at least
| </div> | ||
| </div> | ||
| ) | ||
| } No newline at end of file |
There was a problem hiding this comment.
Add a progress scrubber to allow the user to move forward and backward arbitrarily. Alternatively a +10s/-10s button will do
| { assignment: "Assignment 1", avgSimilarity: 23.5 }, | ||
| { assignment: "Assignment 2", avgSimilarity: 18.2 }, | ||
| { assignment: "Assignment 3", avgSimilarity: 31.8 }, | ||
| { assignment: "Assignment 4", avgSimilarity: 15.4 }, |
There was a problem hiding this comment.
Again static data, where will these similarities come from? where will they be processed?
| </CardHeader> | ||
| <CardContent> | ||
| <div className="text-2xl font-bold">234</div> | ||
| <p className="text-xs text-muted-foreground">+3.5% from Assignment 3</p> |
There was a problem hiding this comment.
This is defined as an inline html, not even a variable. We need a frontend, not just html css
| title: "Weekly Assignment 5", | ||
| description: "Dynamic Programming", | ||
| date: "2024-01-15", | ||
| size: "2.4 MB", |
There was a problem hiding this comment.
What exactly will this report contain? Who said we are making reports? where will the reports be generated?
| @@ -0,0 +1,11 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
This file is created but never used
There was a problem hiding this comment.
Please keep lock files out of the git repository
anuragrao04
left a comment
anuragrao04
left a comment
There was a problem hiding this comment.
Summary: we need a frontend, not just a pretty html css page. Please think and build about API contracts, where the data will come from, where it's computed and stored, etc. Also please think about the random features like report generation stuff. We never told we're doing that. Moreover, numbers like 'submissions', 'detections' have to be computed and stored somewhere and you'll need to talk to the backend person about these things. The backend person should in turn talk to the person building the entire pipeline to actually compute and store this.
At the moment, this is just a pretty html css web page with very little feature cohesion with the rest of the system. I cannot merge this. Please look into my comments, they explain more
2 participants
No description provided.