Run Alembic migrations on container boot#6
Merged
Conversation
The image shipped without alembic/ or alembic.ini and booted straight into uvicorn, so migrations never ran. Fresh volumes survived via create_all, but any existing deploy drifted on schema changes — e.g. POST /batches 500'd with "column monthly_fee does not exist" after the dues/fee PR. Copy alembic into the image and `alembic upgrade head` before uvicorn. Both revisions are idempotent (0001 = create_all, 0002 = guarded add), so it's safe on fresh and stale DBs alike. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker image shipped without
alembic/oralembic.iniand booted straight into uvicorn, so migrations never ran. Fresh volumes survived viacreate_all, but any existing deploy drifted whenever the schema changed — e.g. after the dues/fee PR,POST /api/batches500'd withcolumn "monthly_fee" of relation "batches" does not exist, which also broke the downstream enrollment / session / payment flows.Fix
alembic/+alembic.iniinto the image.alembic upgrade headbefore uvicorn in theCMD.Both revisions are idempotent (
0001=create_all,0002= guarded add), so this is safe on fresh and stale DBs alike.Verification
Reproduced the broken state (dropped
batches.monthly_feeon a live volume), rebuilt, and booted:0001 → 0002on startup.numeric(10,2)).🤖 Generated with Claude Code