add exit preview params #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewls618
requested review from
bernardodsanderson,
ryanarakawa and
spaulsandhu
spaulsandhu
reviewed
Jan 28, 2026
| <% unless @task_preview_mode == 'true' %> | ||
| <a href="<%= edit_template_path(@template, @auth_token || session[:auth_token] ? { auth_token: @auth_token || session[:auth_token] } : {}) %>" class="base-button" data-turbo="false" style="flex-shrink: 0; padding: 0px 24px;"> | ||
| <% exit_params = {} %> | ||
| <% exit_params[:auth_token] = @auth_token || session[:auth_token] if @auth_token || session[:auth_token] %> |
Member
There was a problem hiding this comment.
This is super confusing to me, when would we ever NOT have an auth_token here?
Author
There was a problem hiding this comment.
I removed the conditional at the end
spaulsandhu
reviewed
Jan 28, 2026
| <a href="<%= edit_template_path(@template, @auth_token || session[:auth_token] ? { auth_token: @auth_token || session[:auth_token] } : {}) %>" class="base-button" data-turbo="false" style="flex-shrink: 0; padding: 0px 24px;"> | ||
| <% exit_params = {} %> | ||
| <% exit_params[:auth_token] = @auth_token || session[:auth_token] if @auth_token || session[:auth_token] %> | ||
| <% exit_params[:external_account_id] = @external_account_id if @external_account_id.present? %> |
Member
There was a problem hiding this comment.
If I'm reading this right, we need the following:
- An
auth_token(which should always be present, right?) - An
account_idor apartnership_idwhich would then determine where we redirect back to, either retain side or partner hub.
Is that correct?
spaulsandhu
approved these changes
Jan 28, 2026
Member
spaulsandhu
left a comment
spaulsandhu
left a comment
There was a problem hiding this comment.
I was going to suggest leveraging some kind of presenter object here, but I think a couple of conditionals in the view are fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: CP-12221
Description
The params were not being persisted when exiting preview mode.
Changes
Demo
https://www.loom.com/share/962ebfa883524f0c81d763df3226f1df