Conversation
Member
|
Could we just rename this repo or dos that have a conflict with other stuff? |
Collaborator
Author
|
I didn't know renaming repos was an option, that's great. No dependency so far on the repo name, go ahead and I'll update this PR accordingly. Thanks! |
Member
|
All done 🙂 |
Collaborator
Author
|
All good from my side now. As an aside, I couldn't find another repo with projects taking a NuGet dependency on Carter, they all seem to use Git submodules. Do we plan on changing this? |
Collaborator
Author
|
Thanks, I pushed an update that points to the right repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CarterCommunity/Carter#311
Instead of copying the workflow file around, this sets us up to use reusable workflows, where a workflow can call another another one, even if it's defined in another repository.
In our case, this means the following:
One aspect that is not ideal is that we (based on my suggestion) named this repository
.github, and GitHub expects workflow files to live in the.github/workflowsdirectory.This means that, in the other repos, when we want to call the workflow in this repository, we'll have a double
.githubsegment in the path, which may look weird and/or confuse people:If we don't like this, I think it's easy enough to create another repo that we can call
reusable-workflowsor something along those lines, and get rid of this one.Up to you.