refactor for consistency move about compose ui#3196
Closed
ilyaZar wants to merge 1 commit into
Closed
Conversation
- keep about activity focused on lifecycle setup
Member
|
This is wrong. The composable should NOT be moved to the activity itself. The composables should be in the ui package/directory. About activity was fine, I explicitly named it as an example because it was fine. |
Contributor
Author
|
argh sry i missread the other commnet |
Member
|
No worries, it happens :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keep about activity focused on lifecycle
is meant to complement what has been indicated as repo style/consistency here #3184 (review)