Merged
Conversation
Contributor
Author
|
P.S. Not sure if I am meant to bump the version in pyproject.toml or not. |
ryan-odea
approved these changes
Dec 5, 2025
Collaborator
ryan-odea
left a comment
There was a problem hiding this comment.
This looks good to me - thanks for checking additional python versions.
Collaborator
Since this is just tests and config files, and we aren't planning to push to pypi, perhaps we hold off on bumping the version. If you want to initiate an update to pypi, I think it requires a different version |
Contributor
Author
|
thanks - that's very helpful info about the version number - I won't bump it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ryan
I had a look at this.
Great work.
As far as I can see the tests also pass under Python 3.13 and 3.14, so I see no reason not to add them into the project - unless you know of a reason.
Also I added the dev dependency-group to the pyproject.toml with pytest, black, isort, and the packages for the docs site (so those packages get installed when one runs
uv sync).You can test under different versions of Python quite quickly with uv virtual envs as follows:
uv venv --python 3.13 source .venv/bin/activate uv sync uv run pytest deactivate(I got one tiny warning about one of the dependency packages under Python 3.14 - but that's for that package to fix.)
(And I had to add
pytest.approx()to the parallel test - but obvs not reasonable to expect different architectures to be equal down to like 10 d.p.)cheers
Tom