Conversation
remlapmot
reviewed
Dec 9, 2025
Contributor
remlapmot
left a comment
remlapmot
left a comment
There was a problem hiding this comment.
Great work Ryan.
Possible small improvement to tests suggested.
Collaborator
Author
Thanks! Looks much cleaner (and probably preforms a bit better) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage of version-wise, this comes after #24
This adds the visit option - rather than having
visit_process=True, entering the visit process is inferred ifvisit_colnameis given.A bug was also found in the python version where censoring weights (LTFU) were not being multiplied by the base adherence weights.