Skip to content

Push lxykzmqwzlyl#3

Open
Premiermoney wants to merge 5 commits into
Cdult:Hoodfrom
Premiermoney:push-lxykzmqwzlyl
Open

Push lxykzmqwzlyl#3
Premiermoney wants to merge 5 commits into
Cdult:Hoodfrom
Premiermoney:push-lxykzmqwzlyl

Conversation

@Premiermoney
Copy link
Copy Markdown
Member

Motivation for the change, related issues

Implementation details

Testing Instructions (or ideally a Blueprint)

Vite supports imports such as Version: ImageMagick 7.1.0-49 Q16-HDRI x86_64 20471 https://imagemagick.org
Copyright: (C) 1999 ImageMagick Studio LLC
License: https://imagemagick.org/script/license.php
Features: Cipher DPC HDRI Modules OpenMP(5.0) 
Delegates (built-in): bzlib fontconfig freetype gslib heic jng jp2 jpeg lcms lqr ltdl lzma openexr png ps raw tiff webp xml zlib
Compiler: gcc (4.2)
Usage: import [options ...] [ file ]

Image Settings:
  -adjoin              join images into a single multi-image file
  -border              include window border in the output image
  -channel type        apply option to select image channels
  -colorspace type     alternate image colorspace
  -comment string      annotate image with comment
  -compress type       type of pixel compression when writing the image
  -define format:option
                       define one or more image format options
  -density geometry    horizontal and vertical density of the image
  -depth value         image depth
  -descend             obtain image by descending window hierarchy
  -display server      X server to contact
  -dispose method      layer disposal method
  -dither method       apply error diffusion to image
  -delay value         display the next image after pausing
  -encipher filename   convert plain pixels to cipher pixels
  -endian type         endianness (MSB or LSB) of the image
  -encoding type       text encoding type
  -filter type         use this filter when resizing an image
  -format "string"     output formatted image characteristics
  -frame               include window manager frame
  -gravity direction   which direction to gravitate towards
  -identify            identify the format and characteristics of the image
  -interlace type      None, Line, Plane, or Partition
  -interpolate method  pixel color interpolation method
  -label string        assign a label to an image
  -limit type value    Area, Disk, Map, or Memory resource limit
  -monitor             monitor progress
  -page geometry       size and location of an image canvas
  -pause seconds       seconds delay between snapshots
  -pointsize value     font point size
  -quality value       JPEG/MIFF/PNG compression level
  -quiet               suppress all warning messages
  -regard-warnings     pay attention to warning messages
  -repage geometry     size and location of an image canvas
  -respect-parentheses settings remain in effect until parenthesis boundary
  -sampling-factor geometry
                       horizontal and vertical sampling factor
  -scene value         image scene number
  -screen              select image from root window
  -seed value          seed a new sequence of pseudo-random numbers
  -set property value  set an image property
  -silent              operate silently, i.e. don't ring any bells 
  -snaps value         number of screen snapshots
  -support factor      resize support: > 1.0 is blurry, < 1.0 is sharp
  -synchronize         synchronize image to storage device
  -taint               declare the image as modified
  -transparent-color color
                       transparent color
  -treedepth value     color tree depth
  -verbose             print detailed information about the image
  -virtual-pixel method
                       Constant, Edge, Mirror, or Tile
  -window id           select window with this id or name
                       root selects whole screen

Image Operators:
  -annotate geometry text
                       annotate the image with text
  -colors value        preferred number of colors in the image
  -crop geometry       preferred size and location of the cropped image
  -encipher filename   convert plain pixels to cipher pixels
  -extent geometry     set the image size
  -geometry geometry   preferred size or location of the image
  -help                print program options
  -monochrome          transform image to black and white
  -negate              replace every pixel with its complementary color 
  -quantize colorspace reduce colors in this colorspace
  -resize geometry     resize the image
  -rotate degrees      apply Paeth rotation to the image
  -strip               strip image of all profiles and comments
  -thumbnail geometry  create a thumbnail of the image
  -transparent color   make this color transparent within the image
  -trim                trim image edges
  -type type           image type

Miscellaneous Options:
  -debug events        display copious debugging information
  -help                print program options
  -list type           print a list of supported option arguments
  -log format          format of debugging information
  -version             print version information

By default, 'file' is written in the MIFF image format.  To
specify a particular image format, precede the filename with an image
format name and a colon (i.e. ps:image) or specify the image type as
the filename suffix (i.e. image.ps).  Specify 'file' as '-' for
standard input or output. that yield either a URL or a filesystem path of the imported file. This is useful for shipping static files with the repository. This PR adds a support for the same ?url syntax to plain Node.js to enable testing the code using these paths.
Creates a new PHP extension that ships the post_message_to_js() function. This allows
using it in the CLI SAPI (`php.cli()`) and not just in the WASM SAPI (`php.run()`)

## Remaining work

* Rebuild all PHP versions
* Add unit tests

## Testing instructions

Confirm the CI tests pass
We'll be reusing concatUint8Arrays() in more packages, e.g. php-wasm/universal. This
PR moves it into a globally available package like `@php-wasm/utils`

## Testing instructions

This is a small change. Just confirm the CI is green.
useHostFilesystem() mounts all top-level directories from the host filesystem in PHP.wasm's VFS.

This PR ensures it also mounts top-level symlinks to directories.

For example, on Mac, the top level /var directory is a symlink
to /private/var. If we don't follow the symlink, we won't mount
it and PHP will use a separate, VFS-scoped /var directory. This,
in turn, will break the following use-case:

 * PHP.wasm writes a PHP script to a temporary directory in
 * /private/var/folders/.../T/ in the host filesystem.
 * PHP.wasm calls proc_open() to execute the script in the host filesystem.

This PR solves it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants