-
Notifications
You must be signed in to change notification settings - Fork 2
feat: expose status_v3 in cli #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelshin
wants to merge
1
commit into
main
Choose a base branch
from
mshin/expose-detailed-status-in-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| from types import SimpleNamespace | ||
|
|
||
| import pytest | ||
|
|
||
| from centml.cli.cluster import DeploymentStatus, _get_status_error_messages | ||
| from centml.sdk import ApiException | ||
|
|
||
|
|
||
| def test_status_error_messages_include_revision_and_pod_messages(): | ||
| cclient = SimpleNamespace( | ||
| get_status_v3=lambda _id: SimpleNamespace( | ||
| revision_pod_details_list=[ | ||
| SimpleNamespace( | ||
| revision_number=3, | ||
| error_message="revision failed", | ||
| pod_details_list=[ | ||
| SimpleNamespace(name="pod-a", error_message="image pull failed"), | ||
| SimpleNamespace(name="pod-b", error_message=None), | ||
| ], | ||
| ) | ||
| ] | ||
| ) | ||
| ) | ||
| deployment = SimpleNamespace(id=123, status=DeploymentStatus.ACTIVE) | ||
|
|
||
| messages = _get_status_error_messages(cclient, deployment) | ||
|
|
||
| assert messages == ["revision 3: revision failed", "revision 3 / pod-a: image pull failed"] | ||
|
|
||
|
|
||
| def test_status_error_messages_do_not_repeat_duplicate_messages(): | ||
| duplicate_message = "one or more objects failed to apply" | ||
| cclient = SimpleNamespace( | ||
| get_status_v3=lambda _id: SimpleNamespace( | ||
| revision_pod_details_list=[ | ||
| SimpleNamespace( | ||
| revision_number=None, | ||
| error_message=duplicate_message, | ||
| pod_details_list=[SimpleNamespace(name=None, error_message=duplicate_message)], | ||
| ) | ||
| ] | ||
| ) | ||
| ) | ||
| deployment = SimpleNamespace(id=123, status=DeploymentStatus.ACTIVE) | ||
|
|
||
| assert _get_status_error_messages(cclient, deployment) == [f"revision: {duplicate_message}"] | ||
|
|
||
|
|
||
| def test_status_error_messages_fall_back_to_legacy_status_message(): | ||
| legacy_status = SimpleNamespace(error_message="legacy service failure") | ||
|
|
||
| def get_status_v3(_id): | ||
| raise ApiException(status=404) | ||
|
|
||
| cclient = SimpleNamespace(get_status_v3=get_status_v3, get_status=lambda _id: legacy_status) | ||
| deployment = SimpleNamespace(id=123, status=DeploymentStatus.ACTIVE) | ||
|
|
||
| assert _get_status_error_messages(cclient, deployment) == ["legacy service failure"] | ||
|
|
||
|
|
||
| def test_status_error_messages_reraises_unexpected_v3_errors(): | ||
| def get_status_v3(_id): | ||
| raise ApiException(status=500) | ||
|
|
||
| cclient = SimpleNamespace(get_status_v3=get_status_v3) | ||
| deployment = SimpleNamespace(id=123, status=DeploymentStatus.ACTIVE) | ||
|
|
||
| with pytest.raises(ApiException): | ||
| _get_status_error_messages(cclient, deployment) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just removed this file