Skip to content

Add formal definitions for edge visibility type#1361

Merged
david-lively merged 3 commits into
mainfrom
edge-visibility-type
May 13, 2026
Merged

Add formal definitions for edge visibility type#1361
david-lively merged 3 commits into
mainfrom
edge-visibility-type

Conversation

@j9liu

@j9liu j9liu commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR is similar in nature to #1329.

The EXT_mesh_primitive_edge_visibility extension defines constants for visibility types. but the schemas themselves do not capture these values. To represent these more formally, this redefines ExtensionExtMeshPrimitiveEdgeVisibility as a derived class from the autogenerated spec one.

I modelled the constants after the way they are generated for other classes by our tools, preferring struct with static const over enum classes.

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • [ ] I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • [ ] I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu j9liu changed the title Edge visibility type Add formal definitions for edge visibility type May 7, 2026

@david-lively david-lively left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-lively
david-lively merged commit 6ac00ee into main May 13, 2026
28 checks passed
@david-lively
david-lively deleted the edge-visibility-type branch May 13, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants