Skip to content

Optimization of offsets for MAXAR_content_geojson string properties#1415

Merged
j9liu merged 5 commits into
mainfrom
maxar-offset-opt
Jul 16, 2026
Merged

Optimization of offsets for MAXAR_content_geojson string properties#1415
j9liu merged 5 commits into
mainfrom
maxar-offset-opt

Conversation

@timoore

@timoore timoore commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

Offsets to string property values were always stored as 64 bit integers. This PR chooses the appropriate size, which can be UINT8, UINT16, UINT32, or UINT64

Issue number or link

#1414

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Remaining Tasks

Testing plan

Run a client with a MAXAR_content_geojson tileset and verify that string metadata is still coherent.

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu
j9liu self-requested a review July 13, 2026 17:53

@j9liu j9liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timoore! I tried this out in Unreal and confirmed that the string data still returns correctly.

Just a few minor comments before merge.

Comment thread CesiumVectorData/src/GltfConverter.cpp
Comment thread CesiumVectorData/src/GltfConverter.cpp Outdated
Comment thread CesiumVectorData/src/GltfConverter.cpp Outdated
@j9liu j9liu added this to the August 2026 Release milestone Jul 13, 2026

@j9liu j9liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timoore !

@j9liu
j9liu merged commit 004a56a into main Jul 16, 2026
28 checks passed
@j9liu
j9liu deleted the maxar-offset-opt branch July 16, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants