Add GeoJson as source for CesiumCartographicPolygon#706
Open
gojushin wants to merge 13 commits into
Open
Conversation
gojushin
changed the title
gojushin
force-pushed
the
impl_geoJsonCutouts
branch
from
July 9, 2026 15:32
f187d0a to
cf6f3cc
Compare
Collaborator
|
Thanks for the PR @gojushin! Confirmed that we have a CLA from you on hand, we'll take a look at this when we get the chance. 🙏 |
j9liu
self-requested a review
July 20, 2026 17:52
- Added CesiumCartographicGeoJsonPolygon + Tests - Refactored CesiumCartographicPolygon to use a shared base class with CesiumCartographicGeoJsonPolygon - Fixed a bug where pressing "Trobleshoot Token" in CesiumGeoJsonDocumentRasterOverlay can not trigger.
Reverted new class-approach to use the pre-existing Spline logic
This reverts commit 17a94b4.
gojushin
force-pushed
the
impl_geoJsonCutouts
branch
from
July 21, 2026 08:24
cf6f3cc to
e6ceb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces efficient cutouts using
.geoJsonfiles.It builds on the functionality introduced in this PR and primarily extends
CesiumCartographicPolygonto support loading aSplineComponent from a.geoJsonfile.Using
CesiumCartographicPolygoninstead ofCesiumGeoJsonDocumentRasterOverlayfor hiding the tiles has a significant advantage: tiles that are fully contained within the polygon are not just visually hidden, but are never loaded in the first place, resulting in a net performance improvement in these scenarios.While implementing this feature, I realized it would be beneficial for the workflow to support both directions (
.geoJson↔Spline)... So I also added the ability to export Splines as.geoJsonfiles, allowing them to be further integrated into the Cesium ecosystem. This can however be easily taken out again, if the functionality is undesired.Issue number or link
This implements the functionality discussed here:
https://community.cesium.com/t/introducing-efficient-geojson-cutouts/46510
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Remaining Tasks
None
Testing plan
I tested my changes using .geoJson files created in QGIS for each of the 3 new modes (FromDocument, FromURL and FromIon).
The .geoJson Writing has been tested by opening it in QGIS.