Add CesiumVectorPointStyle for GeoJSON point rendering#708
Open
baruchInsert-tech wants to merge 1 commit into
Open
Add CesiumVectorPointStyle for GeoJSON point rendering#708baruchInsert-tech wants to merge 1 commit into
baruchInsert-tech wants to merge 1 commit into
Conversation
Contributor
Author
Note on the point fill/outline style types
I'm happy to introduce a generic |
j9liu
self-requested a review
July 20, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@j9liu
@azrogers
Description
Exposes a managed point style so
CesiumGeoJsonDocumentRasterOverlaycan render GeoJSONPointandMultiPointfeatures, which were previously dropped.Changes
CesiumVectorPointStyle(radius, fill + fill style, outline + outline style) and apointStylefield onCesiumVectorStyle. The default enables fill, since the nativePointStyledefault (no fill, no outline) renders nothing.pointStyleto/from the nativeVectorStyle::pointinCesiumVectorStyleConversions.h, mirroring the existing polygon style.ConfigureReinterop.csso Reinterop generates its interop header.TestCesiumVectorStyle.cs.The overlay's inspector needs no change -
CesiumGeoJsonDocumentRasterOverlayEditordraws the style withPropertyField(..., includeChildren: true), so the new Point Style section appears automatically.Native dependency
This PR is the managed side only and intentionally does not bump the cesium-native submodule.
It compiles against the currently pinned native (
PointStyleandVectorStyle::pointalready exist there), but points will not actually render until the cesium-native submodule is advanced to a version that includes theGeoJsonDocumentRasterOverlaypoint-rasterization support - which is already merged in cesium-nativemain. Until that bump lands,pointStyleis configurable but has no visible effect.Suggested follow-up: bump the submodule to a cesium-native version containing that support (coordinated separately / with the next native update).
Issue number or link
#707
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Remaining Tasks
Bump the submodule to a cesium-native version containing the
GeoJsonDocumentRasterOverlaypoint-rasterization support.Testing plan
CesiumVectorPointStyledefaults and configuration.Point/MultiPointfeatures from a GeoJSON document rendered onto a tileset viaCesiumGeoJsonDocumentRasterOverlay.Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.