Create partial reference implementation for BENTLEY_materials_planar_fill (backgroundFill)#13266
Closed
markschlosseratbentley wants to merge 9 commits into
Closed
Create partial reference implementation for BENTLEY_materials_planar_fill (backgroundFill)#13266markschlosseratbentley wants to merge 9 commits into
markschlosseratbentley wants to merge 9 commits into
Conversation
Contributor
|
Thank you for the pull request, @markschlosseratbentley! ✅ We can confirm we have a CLA on file for you. |
6 tasks
Contributor
Author
|
Closing in favor of #13178 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP! Please do not review.
Partially implements glTF specification BENTLEY_materials_planar_fill.
backgroundFillwireframeFill- No-op for now. Relies on AddEdgeDisplayModeenum for controlling edge rendering #13192.behind- No-op for now. Will handle in a follow-up PR (Create partial reference implementation for BENTLEY_materials_planar_fill (behind) #13178)Issue number and link
Partially fixes #12890
Testing plan
View deployed Sandcastle Sample here. Notice how the middle polygon is colorized as
black, the same as the viewport background.Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change