Skip to content

Fix regression where SkyBox.show = false is ignored#13315

Merged
lukemckinstry merged 5 commits into
mainfrom
fix-skybox-show
Mar 20, 2026
Merged

Fix regression where SkyBox.show = false is ignored#13315
lukemckinstry merged 5 commits into
mainfrom
fix-skybox-show

Conversation

@markschlosseratbentley

Copy link
Copy Markdown
Contributor

Description

This PR fixes SkyBox.show being ignored when set to false. See linked issue for more details and discussion. This PR fixes a regression introduced by #13153 which refactored SkyBox to delegate to CubeMapPanorama.

Issue number and link

#13311

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @markschlosseratbentley!

✅ We can confirm we have a CLA on file for you.

@lukemckinstry

Copy link
Copy Markdown
Contributor

I forgot to mention our strategy here was to have SkyBox implement and delegate all logic to CubeMapPanorama, I added a commit with that slight modification. Does this look ok to you @markschlosseratbentley ?

@markschlosseratbentley

Copy link
Copy Markdown
Contributor Author

I forgot to mention our strategy here was to have SkyBox implement and delegate all logic to CubeMapPanorama, I added a commit with that slight modification. Does this look ok to you @markschlosseratbentley ?

@lukemckinstry LGTM 👍

@lukemckinstry
lukemckinstry added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 78d27c2 Mar 20, 2026
9 checks passed
@lukemckinstry
lukemckinstry deleted the fix-skybox-show branch March 20, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SkyBox.show = false is ignored (regression since 1.139)

2 participants