Fix regression where SkyBox.show = false is ignored#13315
Merged
Conversation
Contributor
|
Thank you for the pull request, @markschlosseratbentley! ✅ We can confirm we have a CLA on file for you. |
Contributor
|
I forgot to mention our strategy here was to have SkyBox implement and delegate all logic to CubeMapPanorama, I added a commit with that slight modification. Does this look ok to you @markschlosseratbentley ? |
Contributor
Author
@lukemckinstry LGTM 👍 |
lukemckinstry
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
SkyBox.showbeing ignored when set tofalse. See linked issue for more details and discussion. This PR fixes a regression introduced by #13153 which refactored SkyBox to delegate toCubeMapPanorama.Issue number and link
#13311
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change