Reduce threshold for discarding small splats#13642
Open
javagl wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for the pull request, @javagl! ✅ We can confirm we have a CLA on file for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces the threshold for a
discardin the splat renderer from 2x2 pixels to ~0.7x0.7 pixels.Issue number and link
#13304
Testing plan
A test data set with a sandcastle:
splatsDiscard.zip
Here is a comparison of rendering that splat data set with JSplat and with CesiumJS:
That moiré effect for CesiumJS is certainly not desired. It's not clear whether this is "related" to this change, because with that early
discard, the splats simply disappeared before it could happen. But maybe that can be tracked in a dedicated issue.Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment