Adjusting CAIP-171 as per last meeting#173
Merged
bumblefudge merged 13 commits intoChainAgnostic:masterfrom Nov 22, 2022
Merged
Adjusting CAIP-171 as per last meeting#173bumblefudge merged 13 commits intoChainAgnostic:masterfrom
bumblefudge merged 13 commits intoChainAgnostic:masterfrom
Conversation
ritave
approved these changes
Nov 16, 2022
Contributor
ritave
left a comment
ritave
left a comment
There was a problem hiding this comment.
Generally looks good with minor asks
CAIPs/caip-171.md
Outdated
| 1. It MUST uniquely identify an open and stateful session. | ||
| 1. It MUST identify a closeable session, and it MUST become invalid | ||
| after a session is closed. | ||
| 1. It MUST remain the same as the identified session's state changes. |
Contributor
There was a problem hiding this comment.
I don't understand this point.
Collaborator
Author
There was a problem hiding this comment.
the identifier remains constant when the state changes, i.e. not content-addressable/hash-based. better phrasing appreciated!
| ## Copyright | ||
|
|
||
| Copyright and related rights waived via | ||
| [CC0](https://creativecommons.org/publicdomain/zero/1.0/). |
Contributor
There was a problem hiding this comment.
Also I'd suggest having the CC0 in the LICENSE file of this repo as well.
That's what we do in Snaps Improvement Proposals
| ## Changelog | ||
|
|
||
| n/a | ||
| - 2022-11-26: add mandatory indexing by session identifier (i.e. CAIP-171 requirement) |
Contributor
There was a problem hiding this comment.
It's a Draft, imho the changelog shouldn't be in it until it's Final, where we could add Errata.
ritave
reviewed
Nov 17, 2022
| caip: 171 | ||
| title: Session Identifiers | ||
| author: Olaf Tomalka (@ritave) | ||
| discussions-to: <URL> |
Contributor
There was a problem hiding this comment.
Suggested change
| discussions-to: <URL> | |
| discussions-to: https://github.com/ChainAgnostic/CAIPs/discussions/176 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB @ritave (can't tag you for review directly)
partly addresses #141 , although #170 is probably the place to further specify session management for shared assumpions. ideally the choice to use #170 session objects would be separate from the choice to use #171 session identifiers, and wallets or users would know what they can assume based on one or both of the standards being conformed to?