feat(#2): integrate Sidebar into dashboard layout#5
Merged
DeFiVC merged 3 commits intoJun 24, 2026
Merged
Conversation
Import Sidebar in layout.tsx and wrap main content in a flex container so the sidebar sits alongside the page content on desktop (lg: 1024px+). MobileNav remains below the flex row for small screens. The Sidebar's existing hidden lg:flex class handles responsive visibility with no extra CSS needed. Closes ChainLearnOfficial#2
✅ Deploy Preview for chainlearn ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add .eslintrc.json with next/core-web-vitals (Next.js strict config) - Add eslint@^8 and eslint-config-next@14 to devDependencies - Update package-lock.json
DeFiVC
approved these changes
Jun 24, 2026
DeFiVC
left a comment
Contributor
There was a problem hiding this comment.
Summary
Integrates the existing Sidebar component into the root layout, implementing issue #2's target layout exactly. The diff is minimal and focused.
What's Changed
-
src/app/layout.tsx: ImportsSidebar, wraps it and<main>in a flex container (<div className="flex flex-1">), keeping<MobileNav />below the flex row for mobile-only visibility. -
.eslintrc.json+package.json: Adds ESLint withnext/core-web-vitalsconfig, required for the CI Lint check to pass. -
package-lock.json: First lockfile in the repo (6,784 lines — expected for new devDependencies).
Blocking Issues
None. ✅
What's Good
- Layout matches issue #2's target spec character-for-character
Sidebarcomponent already handles responsive visibility viahidden lg:flex- MobileNav correctly remains outside the flex row (mobile only)
- Clean, focused, no scope creep
Minor Nits
⚠️ Lockfile additions are expected but inflate the diff — no action needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
What changed
src/app/layout.tsxSidebarfrom@/components/layout/sidebar<main>in a<div className="flex flex-1">container alongside<Sidebar /><MobileNav />stays outside the flex row, below the content areaLayout structure (before → after)
No changes to
sidebar.tsxwere needed — the existinghidden lg:flexclass already handles responsive visibility.How to verify
npm run dev→ open at width > 1024px — sidebar appears on the left with Dashboard, Courses, Rewards, Credentials, and Settings links