feat(dot/rpc): Add offchain_localStorageClear RPC method#4594
feat(dot/rpc): Add offchain_localStorageClear RPC method#4594khssnv wants to merge 6 commits intoChainSafe:developmentfrom
offchain_localStorageClear RPC method#4594Conversation
|
|
1 similar comment
|
|
|
|
||
| fetchWithTimeout(ctx, t, "offchain_localStorageClear", "", &response) | ||
|
|
||
| // TODO assert response |
There was a problem hiding this comment.
Do you need help to finish this?
There was a problem hiding this comment.
Other t.Run instances in this test function are also marked as TODO, so I decided to add this one in the same way. Would you like to keep it as it is, implement this specific t.Run, or implement all three?
There was a problem hiding this comment.
I think would be great to have at least this one implemented
|
@khssnv thanks for the contribution! I looks more like a draft since there are still some TODOs to finish. If that's the case, could you please convert it to a draft while you are working on it? |
Thanks for the review! Converted to draft. |
The RPC method is `offchain_localStorageClear`.
a62ee63 to
78ea723
Compare
Changes
Implements new
offchain_localStorageClearRPC method introduced to the Polkadot SDK in paritytech/polkadot-sdk#7266. Motivation paritytech/polkadot-sdk#7265.Tests
go test ./... -timeout=30m -run "^(Test_OffchainModule_LocalStorageClear|TestOffchainModule_LocalStorageClear|TestOffchainRPC)$"