fix: build static library with PIC - #12
Merged
Merged
Conversation
nflaig
marked this pull request as ready for review
July 10, 2026 14:27
wemeetagain
approved these changes
Jul 10, 2026
matthewkeil
approved these changes
Jul 10, 2026
matthewkeil
added a commit
to ChainSafe/lodestar-z
that referenced
this pull request
Jul 10, 2026
## What changed - add `aarch64-unknown-linux-musl` to the Lodestar-Z native package target matrix - pin hashtree-z to the merged PIC-enabled commit from [ChainSafe/hashtree-z#12](ChainSafe/hashtree-z#12) - pin the Zig ZAPI dependency to the ARM64-musl backport on `zapi-v2.x.0` - keep the npm dependency on `@chainsafe/zapi` 2.0.0, apply the matching target-support backport with a pnpm patch, and bundle the patched dependency for consumers ## Why Lodestar currently receives an ARM64 musl binary from `@chainsafe/blst`. Replacing it with Lodestar-Z without an equivalent artifact would regress Alpine Linux support on ARM64. The first real cross-build also exposed non-PIC objects in hashtree-z, which prevented the native Node.js shared library from linking. The pinned prerequisite commit fixes that linker failure. ## Dependency chain - [ChainSafe/zapi#47](ChainSafe/zapi#47) is backported to `zapi-v2.x.0` - [ChainSafe/hashtree-z#12](ChainSafe/hashtree-z#12) is merged; `build.zig.zon` pins its canonical squash commit using `zig fetch --save=hashtree` ## Validation - complete `aarch64-unknown-linux-musl` ReleaseSafe build through the patched ZAPI 2 CLI - native host ReleaseSafe bindings build - frozen pnpm install - `pnpm lint` - `zig fmt --check build.zig.zon` - 236 binding tests passed - npm package dry run confirms the patched ZAPI 2 dependency is bundled > This PR was written with AI assistance. --------- Co-authored-by: matthewkeil <me@matthewkeil.com> Co-authored-by: bing <spiralladder@fastmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Build the hashtree static library with position-independent code enabled.
Why
The static library is linked into native Node.js shared libraries such as
@chainsafe/lodestar-z. Cross-compiling that addon foraarch64-linux-muslcurrently fails with AArch64 relocation errors and asks for the hashtree C objects to be recompiled with-fPIC.The assembly sources already receive
-fpic; setting the Zig module'spicoption also covers the C sources and makes the complete shared-library link valid.Impact
This unblocks ARM64 musl/Alpine native addon builds while preserving the existing static-library interface.
Validation
zig fmt --check .zig build testzig build -Dtarget=aarch64-linux-muslaarch64-unknown-linux-muslReleaseSafe cross-build