fix: return correct property gindex for ContainerNodeStructType#328
Draft
wemeetagain wants to merge 1 commit intomasterfrom
Draft
fix: return correct property gindex for ContainerNodeStructType#328wemeetagain wants to merge 1 commit intomasterfrom
wemeetagain wants to merge 1 commit intomasterfrom
Conversation
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
dapplion
reviewed
Jul 8, 2023
| // TODO: Support converting a partial tree to a partial value | ||
| getPropertyGindex(): null { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
It's been a while since I dealt with this code, but what about the comment?
ContainerNodeStructType can only parse proofs that contain all the data
Member
Author
There was a problem hiding this comment.
I agree with the comment. I can put in a more effort to make the UX a bit nicer here
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While doing gindex calculations on a BeaconState, noticed that there is a 'bug' in getting gindexes for validator entries.
Description
Remove the overridden getPropertyGindex that prevents calculation of gindices on a ContainerNodeStructType