feat!: implement hashInto() api for as-sha256#382
Merged
Conversation
twoeths
changed the title
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 15, 2024
Member
wemeetagain
left a comment
wemeetagain
left a comment
There was a problem hiding this comment.
Can you add a section to the PR description labeled BREAKING CHANGE that describes what has broken?
Contributor
Author
I just added it 👍 |
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The hashInto() api of hashtree is very efficient in terms of memory allocation for the consumer because they can preallocate output and reuse over multiple hashes, they can also hash into the same input Uint8Array
Description
digest64HashObjectsInto()which is similar todigest64HashObjects()but this does not allocate new HashObjectbyteArrayIntoHashObject()which is similar tobyteArrayToHashObject(), but this does not allocate new HashObjectall of these functions are used by
persistent-merkle-treeandsszin upcoming PRsBREAKING CHANGE
offsetparam tobyteArrayToHashObject()so that consumer can use the same big Uint8Array to extract HashObject from a subsection of it without usingsubarray()part of #378