feat: package_updates + dark_mode#424
Open
varunguleriaCodes wants to merge 1 commit intoChainSafe:masterfrom
Open
feat: package_updates + dark_mode#424varunguleriaCodes wants to merge 1 commit intoChainSafe:masterfrom
varunguleriaCodes wants to merge 1 commit intoChainSafe:masterfrom
Conversation
|
|
nflaig
reviewed
Dec 6, 2024
| const keyFromCaseMap = casingMap[fieldName]; | ||
| if (keyFromCaseMap === undefined) { | ||
| throw Error(`casingMap[${fieldName}] not defined`); | ||
| throw Error(`casingMap[${String(fieldName)}] not defined`); |
Member
There was a problem hiding this comment.
why is this required? fieldName should be type string
Author
There was a problem hiding this comment.
Hi @nflaig when I ran the build command this error was showing up "Implicit conversion of a 'symbol' to a 'string' will fail at runtime. Consider wrapping this expression in 'String(...)'. " to overcome this I applied typecasting
nflaig
reviewed
Jan 12, 2025
Member
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
merge conflicts need to be resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dependencies update + Dark Mode
Description
Update the dependencies to the latest version + adds a dark mode into the page, the dark mode looks like this->
Closes #issue_number
#407
Steps to test or reproduce