Accept template arguments as a string of fully qualified type names#3
Open
FramePerfection wants to merge 1 commit into
Open
Accept template arguments as a string of fully qualified type names#3FramePerfection wants to merge 1 commit into
FramePerfection wants to merge 1 commit into
Conversation
… the 'TemplateGeneratorAttribute' constructor
Member
Author
|
This is more of a proof of concept than a serious attempt to implement this, but since the target branch is still a draft pull-request itself, might it be okay to merge this anyways? It's missing documentation, but that should probably happen on the "main" pull-request anyways, given that the exact interface hasn't even been fully shaped yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the following code to generate implementations for
System.SingleandSystem.Doubleby transforming the string constantNUMERIC_TYPESto their best matchingINamedTypeSymbols based on the generator's semantic model.This eliminates the need to write out the set of types in each template delegate that expects the same "class" (in a mathematical sense) of objects, such as the numerics in this example.
The implementation is somewhat dirty, creating an exclusive relationship between the
fullyQualifiedTypeNamesandtypesfields inTemplateGeneratorAttribute, as well as the rather speculative implementation of the attribute argument evaluation in theTemplateGenerator.