Skip to content

feat: add weekly-review skill#3

Open
saiboyizhan wants to merge 2 commits intoChatAndBuild:mainfrom
saiboyizhan:weekly-review
Open

feat: add weekly-review skill#3
saiboyizhan wants to merge 2 commits intoChatAndBuild:mainfrom
saiboyizhan:weekly-review

Conversation

@saiboyizhan
Copy link

Summary

Adds a Weekly Review skill that helps users reflect on the past week and plan the next one.

  • Gathers data from connected tools (Calendar, GitHub, Notion, Slack, Linear/Jira) when available
  • Falls back to manual input when no integrations are connected
  • Produces a structured review: wins, in-progress items, reflection, and next-week priorities
  • Concise, actionable output — skips empty sections, no fluff

Why this skill?

Weekly review is one of the most common productivity workflows, but there's currently no skill for it. Out of 1400+ skills in the repo, there's a daily-meeting-update but nothing for weekly cadence. This fills that gap by combining cross-tool data with user reflection.

Skill structure

Phase 1: GATHER  → Collect data from available tools + ask user
Phase 2: REVIEW  → Summarize: wins, open items, key moments
Phase 3: PLAN    → Set 3-5 priorities for next week
Phase 4: OUTPUT  → Formatted markdown review

Checklist

  • SKILL.md with valid frontmatter (id, name, description, category)
  • Category: productivity
  • Under 4000 token limit (~759 words)
  • No external URLs
  • No prompt injection patterns
  • Includes usage examples

harshinimm added a commit to harshinimm/chatchat-skills that referenced this pull request Mar 12, 2026
markusha77 pushed a commit that referenced this pull request Mar 17, 2026
@greptile-apps
Copy link

greptile-apps bot commented Mar 18, 2026

Greptile Summary

This PR adds a new weekly-review skill that guides users through a structured 4-phase productivity workflow (Gather → Review → Plan → Output) by combining data from connected tools (Calendar, GitHub, Notion, Slack, Linear/Jira) with a short user interview, producing a formatted markdown review with wins, priorities, and follow-ups.

The skill is well-structured and fills a genuine gap in the repo's productivity skill set. However, there are two notable logic issues and one convention inconsistency to address before merging:

  • No consent before pulling tool data: The skill instructs Claude to silently pull data from all connected integrations without first asking the user. This contradicts the consent-first pattern established in the existing daily-meeting-update skill ("Always ask before pulling from any integration") and raises privacy concerns, particularly for tools like Slack and Notion that may contain sensitive personal content.
  • "Unplanned Work" is analyzed but never output: Phase 2 instructs Claude to classify items into four buckets, including "Unplanned Work," but the Output Format has no corresponding section for this category. Any data classified as unplanned will be silently lost.
  • No concrete tool detection mechanism: Unlike daily-meeting-update, which provides specific shell commands and API checks per integration, this skill only says "silently check which tools are connected" with no implementation guidance, which may lead to inconsistent or hallucinated behavior.
  • Category mismatch: The PR checklist claims Category: productivity while the actual frontmatter uses category: Lifestyle — the value used in the file is valid in the repo, but the discrepancy should be resolved.

Confidence Score: 3/5

  • The skill has clear value but two logic-level issues (missing output section, missing user consent) should be resolved before merging.
  • The overall structure and intent of the skill are solid, and it introduces no security vulnerabilities. The two P1 issues (silent data pull without consent, and the "Unplanned Work" analysis category having no corresponding output section) are real behavioral bugs that would result in data loss and potential user privacy concerns. They are straightforward to fix but are meaningful enough to warrant a revision before merging.
  • skills/weekly-review/SKILL.md — the consent flow and output format alignment need to be addressed.

Important Files Changed

Filename Overview
skills/weekly-review/SKILL.md New skill file introducing a 4-phase weekly review workflow; has two logic issues: tools are pulled silently without user consent (unlike the consent-first pattern established in the repo), and the "Unplanned Work" category analyzed in Phase 2 has no corresponding section in the Output Format, causing that data to be silently dropped.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([User triggers skill]) --> B[Phase 1: GATHER]
    B --> B1[Silently check connected integrations]
    B1 --> B2{Tools available?}
    B2 -->|Yes| B3[Pull data from Calendar / GitHub / Notion / Slack / Linear/Jira]
    B2 -->|No| B4[Ask user to describe their week manually]
    B3 --> B5[Ask 4 follow-up questions:\nHighlight / Struggle / Carry-over / Next week]
    B4 --> C

    B5 --> C[Phase 2: REVIEW]
    C --> C1[Categorize into:\nCompleted / In Progress / Blocked+Dropped / Unplanned Work]
    C1 --> C2[Identify patterns:\nmeeting overload / context-switching / planned vs actual gap]

    C2 --> D[Phase 3: PLAN]
    D --> D1[Set 3–5 specific, ranked priorities for next week]
    D1 --> D2[Suggest: items to delegate, time blocks, follow-ups]

    D2 --> E[Phase 4: OUTPUT]
    E --> E1[This Week in Numbers]
    E --> E2[Wins]
    E --> E3[Still in Progress]
    E --> E4[Didn't Get Done]
    E --> E5[Key Decisions & Discussions]
    E --> E6[Reflection]
    E --> E7[Next Week Priorities]
    E --> E8[Follow-ups]

    style C1 fill:#ffcccc,stroke:#cc0000
    style B3 fill:#ffcccc,stroke:#cc0000
Loading

Last reviewed commit: "fix: use valid categ..."

Comment on lines +33 to +43
### Step 1: Check available integrations

Silently check which tools are connected. Do NOT fail if none are available — the skill works with manual input too.

| Source | What to pull |
|--------|-------------|
| **Calendar** | This week's meetings — count, key ones attended |
| **GitHub** | PRs merged/opened/reviewed, commits, issues closed |
| **Notion** | Tasks completed, tasks still open |
| **Slack** | Channels with most activity, any saved/starred messages |
| **Linear/Jira** | Tickets completed, tickets in progress, tickets created |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Silent data pull without user consent

The skill instructs Claude to silently pull data from Calendar, GitHub, Notion, Slack, and Linear/Jira without first asking for user permission. This directly conflicts with the consent-first principle established in the existing daily-meeting-update skill, which explicitly states: "Consent before access — Always ask before pulling from any integration" and asks the user before accessing each integration.

Pulling Slack messages, calendar events, and Notion tasks automatically is a privacy concern — users may be working across personal and professional accounts and should explicitly approve which sources to pull from. Consider mirroring the pattern from daily-meeting-update: detect integrations silently, then ask the user which ones to pull from before pulling any data.

Comment on lines +60 to +67
## Phase 2: Review

Analyze gathered data and user input. Organize into:

- **Completed**: Things that got done (from tools + user input)
- **In Progress**: Started but not finished
- **Blocked / Dropped**: Things that didn't move and why
- **Unplanned Work**: Things that came up unexpectedly (meetings, urgent bugs, ad-hoc requests)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 "Unplanned Work" category has no output section

Phase 2 instructs Claude to classify work into four categories: Completed, In Progress, Blocked/Dropped, and Unplanned Work. However, the Output Format in the skill (lines 88–126) has no corresponding section for "Unplanned Work." The closest sections are ## Wins, ## Still in Progress, and ## Didn't Get Done — but none of them map to unexpected, ad-hoc work that came up during the week.

This means any data classified as "Unplanned Work" during Phase 2 is silently dropped and never surfaced to the user. This is especially problematic since the skill explicitly highlights unplanned work (meetings, urgent bugs, ad-hoc requests) as a meaningful category for reflection. A ## Unplanned & Reactive Work section should be added to the Output Format, or the Phase 2 analysis categories should be aligned with what actually appears in the output.

Comment on lines +33 to +35
### Step 1: Check available integrations

Silently check which tools are connected. Do NOT fail if none are available — the skill works with manual input too.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 No concrete integration detection mechanism

The skill says "Silently check which tools are connected" but gives no concrete instructions on how to detect them. Without this, Claude is likely to hallucinate or inconsistently handle tool availability.

Compare this to daily-meeting-update, which provides explicit detection commands per integration:

  • GitHub CLI: gh auth status
  • Jira CLI: check if jira command exists
  • Atlassian MCP: check for mcp__atlassian__* tools
  • Claude Code history: ls ~/.claude/projects/*/*.jsonl

The weekly-review skill should similarly document how to detect Calendar, Notion, Slack, and Linear/Jira availability — or at minimum, note that detection should be done via available MCP tool introspection.

id: weekly-review
name: Weekly Review
description: Generate a structured weekly review by collecting accomplishments, open items, and next-week priorities from connected tools.
category: Lifestyle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Category mismatch between PR checklist and actual frontmatter

The PR description explicitly states Category: productivity in its checklist, but the actual frontmatter uses category: Lifestyle. While Lifestyle is a valid and existing category in this repo, the discrepancy is potentially confusing for reviewers and could indicate an oversight. If Lifestyle is intentional, the PR description checklist should be corrected. If productivity or Business was intended (as used by daily-meeting-update), the frontmatter should be updated.

Suggested change
category: Lifestyle
category: Productivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant