fix(agent): avoid using trigger requestId as platform message id#907
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Walkthrough收窄 变更移除虚拟会话中的 requestId 字段
预期代码审查工作量🎯 3 (Moderate) | ⏱️ ~20 minutes 诗歌
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request removes the 'requestId' property from virtual sessions across the 'extension-agent' package. Specifically, it updates 'ChatLunaAgentTriggerExecutor' to stop passing 'requestId', modifies 'buildVirtualSession' to exclude 'requestId' from its parameters and output, and updates the corresponding unit tests to reflect these changes. There are no review comments, so I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Merging is blocked 让 codex 帮你弄弄签名去 |
7517510 to
9ce5b98
Compare
Summary
Avoid exposing Agent Trigger's internal
requestIdas a platform message id in virtual sessions.Previously, virtual trigger sessions set
event.message.idfromrequestId, which could be mapped tosession.messageIdand later treated by adapters as a real platform message reference.Changes
event.message.idinbuildVirtualSession().requestIdinto virtual session construction.Verification
mocha packages/extension-agent/tests/trigger_session.spec.tstsc -p packages/extension-agent/tsconfig.json --noEmitcorepack yarn fast-build extension-agent