fix(adapter): preserve discovered context windows#917
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Walkthrough在 DeepSeek 和 DouBao 适配器的 Changes模型最大上下文大小修正
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds modelMaxContextSize to the Deepseek and Doubao clients, and increases the fallback context size for Deepseek to 1,000,000 in the shared adapter. The reviewer recommends keeping the Deepseek fallback at 128,000 to avoid API errors with standard models, and suggests adding fallback values for modelMaxContextSize in both the Deepseek and Doubao clients to handle cases where info.maxTokens is undefined.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This pr preserves discovered model context windows for DeepSeek and Doubao chat models.
Bug Fixes
Validation