Fix welcome dialogue delay (AST-152887)#326
Open
cx-aniket-shinde wants to merge 2 commits into
Open
Conversation
- Add _isFreshLoginInProgress flag to track if login initiated in current session - Add _welcomeDialogVisible flag to track Welcome dialog visibility - Update Logout button logic: Enable only when (!fresh OR dialog shown) - Set fresh login flag in OnValidateConnection with immediate UI update - Reset both flags in error handlers and ResetAuthState - Defer UI update in ValidateApiKeyAsync finally block for success cases - Let CompleteAuthenticationSetupAsync handle UI updates after setting flags - Set dialog visible before showing it in ShowOneAssistWelcomeDialog This ensures: ✓ Fresh logins: Logout disabled until Welcome dialog appears ✓ Restored sessions: Logout enabled immediately without dialog ✓ Proper state cleanup on auth failure or logout Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…o background Performance Improvement: - Show Welcome dialog immediately after license check - Move MCP installation to background task (fire-and-forget) - Dialog now appears quickly without waiting for file/network operations - MCP installation completes while user reads Welcome dialog Benefits: ✓ Faster Welcome dialog appearance (removes ~1-3 second delay) ✓ MCP installation happens in background, non-blocking ✓ Better user experience - instant visual feedback after auth ✓ No blocking network/file operations before showing UI Technical Details: - License check still runs upfront (necessary for dialog content) - MCP installation moved to Task.Run for both dialog and restore paths - Error handling for background tasks prevents UI blocking on failure - Welcome dialog can complete normally while installation happens Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cx-aniket-shinde
changed the base branch from
integration/merge-all-pr
to
feature/AST-109633-ui-manager-changes
cx-atish-jadhav
approved these changes
May 13, 2026
cx-atish-jadhav
left a comment
cx-atish-jadhav
left a comment
There was a problem hiding this comment.
Approving on behalf of @cx-rahul-pidde
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist