fix(query): various fixes for passwords and secrets queries #8017
Draft
cx-andre-pereira wants to merge 13 commits intoCheckmarx:masterfrom
Draft
fix(query): various fixes for passwords and secrets queries #8017cx-andre-pereira wants to merge 13 commits intoCheckmarx:masterfrom
cx-andre-pereira wants to merge 13 commits intoCheckmarx:masterfrom
Conversation
… stoping passwords and secrets flags on said files
… commented lines, new allow rules prevent proto files fields from flagging
…generic api key enforces trimmed line starting with 'access'
…Generic Token', improved 2 TF reousrce access rules, added missing positive test for 'Encryption Key' query, added samples (similar to neg28) in negative61 for TF resource access allow rule in 'Encryption Key' query (was also missing test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
This PR is an "expansion" on the fix(query): ensures 'passwords and secrets' queries do not flag fields in 'Proto' files (.proto) #8013, where the focus was lower False Positives associated with ".proto" files. Here fixes for issues that arose during testing done to "passwords and secrets" queries in the aforementioned PR will be the focus.
Proposed Changes
I submit this contribution under the Apache-2.0 license.