Skip to content

slightly less messy error handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChekeredList71 merged 1 commit into from
Oct 11, 2025
Merged

slightly less messy error handling #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,7 @@ func main() {

// if root is just a file
if isSupportedMusicFile(libraryRoot) {
err := runRSGain([]string{libraryRoot}, *quiet)
if err != nil {
errLog.Printf("Something went wrong scanning %s: '%s\n'", libraryRoot, err)
}
runRSGain([]string{libraryRoot}, *quiet)
} else { // if we have a folder, scan them with WalkDir
wg.Add(1)
err := walker(libraryRoot, *quiet)
Expand Down Expand Up @@ -141,7 +138,7 @@ func walker(root string, isQuiet bool) error {
rsgainSemaphore <- 0 //add a slot to the semaphore
defer func() { <-rsgainSemaphore }()

err = runRSGain(audioFiles, isQuiet)
runRSGain(audioFiles, isQuiet)
}
}()
}
Expand All @@ -150,7 +147,7 @@ func walker(root string, isQuiet bool) error {
})
}

func runRSGain(audioFiles []string, isQuiet bool) error {
func runRSGain(audioFiles []string, isQuiet bool) {
cmd := exec.Command("rsgain", append(command, audioFiles...)...)

// Stream output to console if set
Expand All @@ -171,8 +168,6 @@ func runRSGain(audioFiles []string, isQuiet bool) error {
errLog.Printf("Command failed: %s\nError: %v\n", cmd.String(), err)

}

return err
}

func isSupportedMusicFile(path string) bool {
Expand Down
Loading