Open
Conversation
Chethan-rao
force-pushed
the
master
branch
5 times, most recently
from
c59442b to
a4ee9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add
validate_psync_reference_idimplementation for Noon as we can make a Psync usingconnector_request_reference_idand currently core is defaulting ifconnector_transaction_idis not present it fails the Psync.Main PR: juspay/hyperswitch#2886
Additional Changes
Motivation and Context
How did you test it?
Cant be reproduced in envs as either a timeout is required or would need to delete the connector_transaction_id in the DB.
Check for regular proper working of Psyncs in all the cases.
Checklist
cargo +nightly fmt --allcargo clippy