Invalidate Python import caches after pip install#232
Open
jkurashcvx wants to merge 1 commit intomasterfrom
Open
Invalidate Python import caches after pip install#232jkurashcvx wants to merge 1 commit intomasterfrom
jkurashcvx wants to merge 1 commit intomasterfrom
Conversation
Add importlib.invalidate_caches() before pyimport checks in both the devitopro and devito-only install paths. This ensures the already-running Python interpreter sees newly pip-installed packages on disk. This is safe: it only clears the in-process directory listing cache used by Python's import machinery. It does not affect already-loaded modules, filesystem caches, or .pyc files. The only effect is a negligible one-time cost to re-scan directories on the next import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
importlib.invalidate_caches()beforepyimportchecks in both the devitopro and devito-only install paths. This ensures the already-running Python interpreter sees newly pip-installed packages on disk.This is safe: it only clears the in-process directory listing cache used by Python's import machinery. It does not affect already-loaded modules, filesystem caches, or
.pycfiles. The only effect is a negligible one-time cost to re-scan directories on the next import.