Skip to content

add support for 3D arrays in JopInterp#45

Open
jkwashbourne-oss wants to merge 2 commits intomasterfrom
wask/interp3d
Open

add support for 3D arrays in JopInterp#45
jkwashbourne-oss wants to merge 2 commits intomasterfrom
wask/interp3d

Conversation

@jkwashbourne-oss
Copy link
Copy Markdown
Member

@jkwashbourne-oss jkwashbourne-oss commented Apr 3, 2026

  • Adds functionality for 3D arrays

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 92.77108% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.94%. Comparing base (b5518b7) to head (d7cceae).

Files with missing lines Patch % Lines
src/jop_interp.jl 92.77% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   96.02%   95.94%   -0.09%     
==========================================
  Files          40       40              
  Lines        1083     1159      +76     
==========================================
+ Hits         1040     1112      +72     
- Misses         43       47       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkwashbourne-oss
Copy link
Copy Markdown
Member Author

Question, should we change this to JopLinearInterp ?

@nmbader
Copy link
Copy Markdown
Member

nmbader commented Apr 8, 2026

Best to keep the same name to avoid bumping major version.
Speaking of which, remember to update Project.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants