generalize JopSlantStack3D to handle 5D input#18
Merged
Conversation
jkwashbourne-oss
approved these changes
Mar 18, 2026
Member
jkwashbourne-oss
left a comment
jkwashbourne-oss
left a comment
There was a problem hiding this comment.
love that you added unit tests; as long as coverage is good this seems great
| `dhx` and `dhy` are the offset spacings, and `hx0` and `hy0` are the origins of the offset axes. The additional named optional arguments | ||
| along with their default values are, | ||
| The domain of the operator is typically `nz` x `nhx` x `nhy` with precision T, `dz` is the depth spacing (or time interval), | ||
| `dhx` and `dhy` are the offset spacings, and `hx0` and `hy0` are the origins of the offset axes. |
Member
There was a problem hiding this comment.
do we need to specify non-zero origin? what is the use case
Member
Author
There was a problem hiding this comment.
yes we need non-zero origin, for SSOG the origin of hx and hy is negative (-hxmax,-hymax)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generalize JopSlantStack3D to handle 5D input (z,y,x,hx,hy) where the x and y dimensions are passive. This is needed to simplify the application of the operator to 5D subsurface offset volumes, potentially speeding up its application.