consistency between different physics#33
Open
samtkaplan wants to merge 1 commit intomasterfrom
Open
Conversation
…perators collaborative work with @jkwashbourne, @SamKaplan and @miguel-merino
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 80.91% 80.66% -0.25%
==========================================
Files 10 10
Lines 2043 2048 +5
==========================================
- Hits 1653 1652 -1
- Misses 390 396 +6
Continue to review full report at Codecov.
|
samtkaplan
commented
Apr 8, 2021
| The model is 4D with the slowest dimension for model parameter. The earth model property maps to the slow- | ||
| fimension array index via the `state(F).active_modelset` dictionary. | ||
|
|
||
| The model is 4D with the slowest dimension for model parameter velocity [1] or buoyancy [2] in the case that both |
Member
Author
There was a problem hiding this comment.
this paragraph is redundant with the previous paragraph and should be deleted.
jkwashbourne
reviewed
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some work to make logic as consistent as possible between different operators. Joint work with @jkwashbourne and @miguel-merino .