module style 5: add introspective constants#346
Merged
prozacchiwawa merged 78 commits intomainfrom May 7, 2026
Merged
Conversation
… trapped re-constantizing unrelated trees on each other's behalf over and over
…into 20260217-introspective-constants
…and-cleanup funcache coverage, tests, and comments
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 7 total unresolved issues (including 6 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f86cfe. Configure here.
…d the next candidate
…andled by module phase instead
…'s a foreign program. happened to work
aqk
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
High risk because it changes core code generation, environment shaping, and constant evaluation ordering for module compilation, which can affect determinism and correctness of produced CLVM across many programs.
Overview
Enables module-style introspective constants by introducing
ModulePhase(common phase, standalone export phase, and constant-evaluation phase) and threading it throughCompilerOptsandPrimaryCodegen, changing how env shapes are built, finalized, and how exported functions are lambda-wrapped.Reworks constant and helper generation in
codegento produce a stable env first, then evaluate module constants in a dependency-driven order (with convergence checks), and updates deinlining/funcache behavior to include constant dependencies for module compiles and to document cache-key invariants.Adds new module test fixtures and extensive new tests for determinism, cache hit/miss behavior,
@form validation, and constant-cycle failure, plus a new GitHub Actions workflow that builds/tests this repo againstchia-gaming(including atempfiledowngrade and helper scripts to patch and runchia-gaming’s CLSP test suite).Reviewed by Cursor Bugbot for commit 3f308fc. Bugbot is set up for automated code reviews on this repo. Configure here.