Skip to content

20260413 update clvmr main 0 17 5#441

Open
prozacchiwawa wants to merge 11 commits intomainfrom
20260413-update-clvmr-main-0-17-5
Open

20260413 update clvmr main 0 17 5#441
prozacchiwawa wants to merge 11 commits intomainfrom
20260413-update-clvmr-main-0-17-5

Conversation

@prozacchiwawa
Copy link
Copy Markdown
Contributor

@prozacchiwawa prozacchiwawa commented Apr 14, 2026

Note

Medium Risk
Moderate risk due to a major dependency upgrade (clvmr) plus changes to dialect flag handling during program execution, which could subtly affect CLVM operator behavior. CI/toolchain pinning and lockfile churn are lower risk but may impact build reproducibility across environments.

Overview
Upgrades core Rust dependencies to align with clvmr 0.17.5 (and related crypto/random crates), updating Cargo.toml/Cargo.lock and the wasm crate’s dependency set.

Updates classic CLVM execution/compilation glue to match the new clvmr dialect API: replaces raw flag bitmasks with ClvmFlags, adds choose_run_flags, and ensures CompilerOperatorsInternal synchronizes/restores dialect flags around nested run_program calls.

Pins CI and repo toolchains to Rust 1.94.1 across workflows and rust-toolchain.toml/wasm/rust-toolchain.toml, and adjusts the npm wasm build step to set RUSTFLAGS for a custom getrandom backend and MVP CPU target.

Reviewed by Cursor Bugbot for commit f2fcd69. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 14, 2026

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 14, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Native binaries present: cargo wit-component

Location: Package overview

From: ?cargo/getrandom@0.4.2cargo/wit-component@0.244.0

ℹ Read more on: This package | This alert | Why is native code a concern?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/wit-component@0.244.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Ignoring alerts on:

  • cargo/anyhow@1.0.102
  • cargo/libm@0.2.16
  • cargo/malachite-nz@0.9.1
  • cargo/paste@1.0.15
  • cargo/prettyplease@0.2.36
  • cargo/prettyplease@0.2.34
  • cargo/wasmparser@0.244.0
  • cargo/wit-bindgen@0.51.0
  • cargo/wit-bindgen@0.57.1
  • cargo/wit-bindgen-rust@0.51.0
  • cargo/wit-bindgen-rust-macro@0.51.0

View full report

@prozacchiwawa
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore cargo/libm@0.2.16

@prozacchiwawa
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore cargo/malachite-nz@0.9.1

@prozacchiwawa
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore cargo/paste@1.0.15

Comment thread .github/workflows/build-crate.yml
Comment thread src/classic/clvm_tools/stages/stage_2/operators.rs Outdated
aqk
aqk previously approved these changes Apr 27, 2026
aqk
aqk previously approved these changes Apr 27, 2026
@prozacchiwawa
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore cargo/anyhow@1.0.102

@aqk
Copy link
Copy Markdown
Contributor

aqk commented Apr 28, 2026

@SocketSecurity ignore cargo/prettyplease@0.2.34 cargo/wasmparser@0.244.0 cargo/wit-bindgen-rust-macro@0.51.0 cargo/wit-bindgen-rust@0.51.0 cargo/wit-bindgen@0.57.1

@aqk
Copy link
Copy Markdown
Contributor

aqk commented Apr 28, 2026

@SocketSecurity ignore cargo/prettyplease@0.2.34 cargo/wasmparser@0.244.0 cargo/wit-bindgen-rust-macro@0.51.0 cargo/wit-bindgen-rust@0.51.0 cargo/wit-bindgen@0.57.1 cargo/prettyplease@0.2.36 cargo/wit-bindgen@0.51.0

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5cc5d54. Configure here.

Comment thread Cargo.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants