Use an array of zero bytes instead of nil to represent "no fingerprint"#447
Open
Use an array of zero bytes instead of nil to represent "no fingerprint"#447
Conversation
Doing this allows concatenation of an ordered set of signatures to uniquely represent that set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this allows concatenation of an ordered set of signatures to uniquely represent that set.
Note
Medium Risk
Touches dependency fingerprinting and cache-key generation, so mistakes could cause incorrect cache hits/misses or reduced cache effectiveness despite the change being mechanically straightforward.
Overview
Standardizes include fingerprints to a fixed 32-byte SHA-256 digest.
IncludeDesc.fingerprintchanges fromVec<u8>(with “no fingerprint” as empty) to[u8; 32](with “no fingerprint” as all-zero bytes), and all include/namespace/embed paths now populate this field accordingly.This updates cache key construction in
diskcacheto concatenate fixed-size fingerprints deterministically, and adds explicittry_into()conversions where SHA-256 results are produced (e.g.,add_main_fingerprint, module/import hashing).Reviewed by Cursor Bugbot for commit 9c4af97. Bugbot is set up for automated code reviews on this repo. Configure here.