Skip to content

improve hash file naming function#462

Open
aqk wants to merge 5 commits intomainfrom
non-overlapping-hash-file-format
Open

improve hash file naming function#462
aqk wants to merge 5 commits intomainfrom
non-overlapping-hash-file-format

Conversation

@aqk
Copy link
Copy Markdown
Contributor

@aqk aqk commented May 4, 2026

A "hash" file in this context is a file containing the sha256 of the input file. This patch changes the code that generates the name for that file:

  • move to a function to reduce chance of errors in the future, and encapsulate details
  • change transform so that input filename cannot overlap with output filename (eg. ls *hex big.hex, big_hash.hex; hash_file_name(big.hex) -> big_hash.hex)

Note

Medium Risk
Changes the on-disk name of the treehash sidecar written alongside cached .hex outputs, which may break tooling that expects the previous *_hash.hex naming. Logic is small and covered by updated tests, but it affects build artifacts and cache behavior.

Overview
Refactors module cache rebuild output to use a shared hash_file_name() helper when writing the sha256tree sidecar for cached .hex artifacts.

Updates the sidecar naming scheme from the previous *_hash.hex pattern to a non-overlapping "<hex_filename>.hash" form, and adjusts/extends module_cache tests to validate the new naming and paths.

Reviewed by Cursor Bugbot for commit 5791743. Bugbot is set up for automated code reviews on this repo. Configure here.

…input file. This patch changes the code that generates the name for that file:

- move to a function to reduce chance of errors in the future, and encapsulate details
- change transform so that input filename cannot overlap with output filename
(eg. `ls *hex big.hex, big_hash.hex`; hash_file_name(big.hex) -> big_hash.hex)
Comment thread src/tests/compiler/module_cache.rs Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c836f99. Configure here.

Comment thread src/tests/compiler/module_cache.rs Outdated
Base automatically changed from 20260217-introspective-constants to main May 7, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant