Open
Conversation
…input file. This patch changes the code that generates the name for that file: - move to a function to reduce chance of errors in the future, and encapsulate details - change transform so that input filename cannot overlap with output filename (eg. `ls *hex big.hex, big_hash.hex`; hash_file_name(big.hex) -> big_hash.hex)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c836f99. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A "hash" file in this context is a file containing the sha256 of the input file. This patch changes the code that generates the name for that file:
ls *hex big.hex, big_hash.hex; hash_file_name(big.hex) -> big_hash.hex)Note
Medium Risk
Changes the on-disk name of the treehash sidecar written alongside cached
.hexoutputs, which may break tooling that expects the previous*_hash.hexnaming. Logic is small and covered by updated tests, but it affects build artifacts and cache behavior.Overview
Refactors module cache rebuild output to use a shared
hash_file_name()helper when writing the sha256tree sidecar for cached.hexartifacts.Updates the sidecar naming scheme from the previous
*_hash.hexpattern to a non-overlapping"<hex_filename>.hash"form, and adjusts/extendsmodule_cachetests to validate the new naming and paths.Reviewed by Cursor Bugbot for commit 5791743. Bugbot is set up for automated code reviews on this repo. Configure here.