Skip to content

Update contains method to include start position (#34) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattmassicotte merged 2 commits into from
May 26, 2026
Merged

Update contains method to include start position (#34) #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d9681
Update contains method to include start position (#34)
tothambrus11 May 7, 2026
135c887
Add documentation to `contains` and `intersects` methods of LSPRange
tothambrus11 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/LanguageServerProtocol/BasicStructures.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,12 @@ public struct LSPRange: Codable, Hashable, Sendable {
self.end = other.upperBound
}

/// Returns whether the position is in [start, end).
public func contains(_ position: Position) -> Bool {
return position > start && position < end
return position >= start && position < end
}

/// Returns true iff there is any position contained both in `self` and `other`.
public func intersects(_ other: LSPRange) -> Bool {
return contains(other.start) || contains(other.end)
}
Expand Down