Skip to content

Fix PAR request body encoding and add stricter platform guards#57

Closed
radmakr wants to merge 8 commits into
ChimeHQ:mainfrom
radmakr:CoreAtProtocol
Closed

Fix PAR request body encoding and add stricter platform guards#57
radmakr wants to merge 8 commits into
ChimeHQ:mainfrom
radmakr:CoreAtProtocol

Conversation

@radmakr

@radmakr radmakr commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

I needed some of these changes for CoreATProtocol and I think they can safely be merged in here. I'm happy to keep this as a branch in my fork if you think these changes don't make sense.

@radmakr

radmakr commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

I just noticed #54 which on first look seems much more comprehensive than what I did here.

@mattmassicotte

Copy link
Copy Markdown
Contributor

Thank you so much for taking the time to do this! You're right, there are a bunch of pending PRs that need my attention, and I've committed to looking at them first. However, once that's all done, let's revisit and see where we're at?

@radmakr

radmakr commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

looking through all of Emelia's PRs, my PR here probably isn't needed. Once her PRs are merged I'll test locally and then we can probably close this.

@mattmassicotte

Copy link
Copy Markdown
Contributor

Ok, well let's leave it until we actually get to that point. And either way, I really appreciate you doing this!

@radmakr

radmakr commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

I can confirm that after the recent merged PRs, these changes are no longer required. I am closing the PR.

@radmakr radmakr closed this Mar 27, 2026
@mattmassicotte

Copy link
Copy Markdown
Contributor

Well, sorry for the wasted work here. I still really appreciate you doing it!

@radmakr

radmakr commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Not a waste. I learned a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants